fix: modify type check to accept Callable (#317)#318
Open
junah201 wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Open
fix: modify type check to accept Callable (#317)#318junah201 wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
junah201 wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
Conversation
…tform#309) Previously function framework use 0 timeout which is actually "no timeout" restrction. This was causing a problem that when user provides a request timeout to Cloud function, process will still continue and consume resources. In this fix, timeout is enabled; default timeout settings is 5 min, same as Cloud run. To make sure timeout settings will be respected, default settings switched from multi-threads to multi-workers. However, user is still allowed to customize workers/threads by assigning env var. But user need to note that timeout won't work when #thread > 1.
In the get_user_function function within _function_registry.py, change the type check to accept callable objects instead of only types.FunctionType. This allows for instances of classes with a __call__ method.
matthewrobertson
force-pushed
the
main
branch
2 times, most recently
from
4f583a6 to
59fdb1e
Compare
BetaTester772
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the type check in the
get_user_functionfunction within_function_registry.pyto accept callable object instead of only types.FunctionType.Please refer to #317 for more details.
And I already submit a CLA.